View Issue Detail

ID	Project	Category	Submitted / Last Updated
00996	UserSpice	Misc	2020-09-05 20:15:00 / 2020-10-08 04:16:02
Reported	Andrew Weiner	Assigned To	Unassigned
Priority	none	Reported	5.1.5
Status	closed fixed	Resolution Version and Commit	5.1.6 dc83fd
Summary	Division closed while form tag is opened in _spice_shaker.php
Description	<p>There is a form in users/views/_spice_shaker.php at line 164.  The code has the form and divison tags positioned incorrectly causing invalid html.</p> <p>The original row:</p> <p>        <div class="row"><br />          <div class="col-4 offset-2"><br />            <form class="" action="" method="post"><br />              <input type="text" name="search" class="form-control" value="" placeholder="Search all addons" autocomplete="new-password"><br />            </div><br />            <div class="col-3"><br />              <?php if($settings->spice_api != ''){?><br />                <input type="submit" name="goSearch" value="Search" required><br />              <?php } ?><br />            </form><br />          </div><br />          <br><br><br />        </div></p> <p>The corrected row:</p> <p>        <form class="" action="" method="post"><br />            <div class="row mb-5">                     <br />              <div class="col-4 offset-2"><br />                  <input type="text" name="search" class="form-control" value="" placeholder="Search all addons" autocomplete="new-password"><br />              </div><br />              <div class="col-3"><br />                  <?php if($settings->spice_api != ''){?><br />                    <input type="submit" name="goSearch" value="Search" required><br />                  <?php } ?><br />              </div><br />              <!-- <br><br>    -->                  <br />            </div><br />        </form></p> <p>The corrected row follows Bootstrap 4 coding practices.  I placed a bottom margin on the row to create the proper spacing between the row and the displayed plugins as the <br> code did not create adaquate spacing.</p> <p>Please consider updating the master with this code.</p>

November 2021

<p>Thanks Andrew</p>