View Issue Detail

ID	Project	Category	Submitted / Last Updated
00989	UserSpice	Misc	2020-09-05 19:31:10 / 2020-10-08 04:16:02
Reported	Andrew Weiner	Assigned To	Unassigned
Priority	none	Reported	5.1.5
Status	closed fixed	Resolution Version and Commit	5.1.6 2b46ce
Summary	Closing list tag in wrong position in _admin_menu.php if loop.
Description	<p>There is a loop that lists the plugins on the admin page when using the users/views/_admin_menu.php file.</p> <p>Around line 155 the loop will generate the list of the plugins.  The code adds a closing list tag </li> for empty plugins (no opening list tag).  It is placed after the if closing bracket.</p> <p>Here is the code:</p> <p>                if(file_exists($abs_us_root.$us_url_root.'usersc/plugins/'.$t.'/configure.php') && isset($usplugins[$t]) && ($usplugins[$t] == 1)){?><br />                <li><i class=" menu-icon fa fa-bolt"></i><br />                  <a href="<?=$us_url_root.'users/admin.php?view=plugins_config&plugin='.$t?>" ><br />                    <?php<br />                    if($xml->button != ''){<br />                      echo $xml->button;<br />                    }else{<br />                      echo $t;<br />                    } ?><br />                    </a><br />                <?php } ?><br />                </li><br />            <?php  }?></p> <p>Simple fix to move the closing list tag just before the end tag of the if loop.</p> <p>                if(file_exists($abs_us_root.$us_url_root.'usersc/plugins/'.$t.'/configure.php') && isset($usplugins[$t]) && ($usplugins[$t] == 1)){?><br />                    <li><i class=" menu-icon fa fa-bolt"></i><br />                        <a href="<?=$us_url_root.'users/admin.php?view=plugins_config&amp;plugin='.$t?>"><br />                        <?php<br />                            if($xml->button != ''){<br />                              echo $xml->button;<br />                            }else{<br />                              echo $t;<br />                            } ?><br />                        </a><br />                    </li>                    <br />                <?php } ?></p> <p>Please consider including this in the master.</p>

November 2021

<p>Thanks!</p>