View Issue Detail

ID	Project	Category	Submitted / Last Updated
00835	UserSpice	Misc	2020-03-21 20:02:14 / 2020-07-22 20:05:52
Reported	Had3z Same	Assigned To	Unassigned
Priority	low	Reported	5.0.09
Status	closed fixed	Resolution Version and Commit	5.1.1 cd6ac4
Summary	db class does not clear the results when executing bad sql
Description	<pre class="xdebug-var-dump" dir="ltr" style="color: #000000; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">step 1. use the db class to run a good sql<br />step 2. use the db class to run a sql that has a syntax error<br />step 3. notice the $query->results() returns the data from the previus successfully executed query, even if the error boolean is set to true</pre> <pre class="xdebug-var-dump" dir="ltr" style="color: #000000; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;"><strong>object</strong>(<em>DB</em>)[<em>6</em>] <em>private</em> '_pdo' <span style="color: #888a85;">=></span> <strong>object</strong>(<em>PDO</em>)[<em>7</em>] <em>private</em> '_query' <span style="color: #888a85;">=></span> <strong>object</strong>(<em>PDOStatement</em>)[<em>8</em>] <em>public</em> 'queryString' <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'foobar'</span> <em>(length=6)</em> <em>private</em> '_error' <span style="color: #888a85;">=></span> <small>boolean</small> <span style="color: #75507b;">true</span> <em>private</em> '_errorInfo' <span style="color: #888a85;">=></span> <strong>array</strong> <em>(size=3)</em> 0 <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'42000'</span> <em>(length=5)</em> 1 <span style="color: #888a85;">=></span> <small>int</small> <span style="color: #4e9a06;">1064</span> 2 <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'foobar' at line 1'</span> <em>(length=152)</em> <em>private</em> '_results' <span style="color: #888a85;">=></span> <strong>array</strong> <em>(size=1)</em> 0 <span style="color: #888a85;">=></span> <strong>object</strong>(<em>stdClass</em>)[<em>14</em>] <em>public</em> 'id' <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'204'</span> <em>(length=3)</em> <em>public</em> 'userID' <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'1'</span> <em>(length=1)</em> <em>public</em> 'status' <span style="color: #888a85;">=></span> <small>string</small> <span style="color: #cc0000;">'open'</span> <em>(length=4)</em> <em>private</em> '_resultsArray' <span style="color: #888a85;">=></span> <strong>array</strong> <em>(size=0)</em> <em><span style="color: #888a85;">empty</span></em> <em>private</em> '_count' <span style="color: #888a85;">=></span> <small>int</small> <span style="color: #4e9a06;">0</span> <em>private</em> '_lastId' <span style="color: #888a85;">=></span> <small>int</small> <span style="color: #4e9a06;">0</span> <em>private</em> '_queryCount' <span style="color: #888a85;">=></span> <small>int</small> <span style="color: #4e9a06;">6</span></pre>

November 2021

<p>Thanks for this. We didn't write the original DB class, it was a 3rd party class and this is literally the way it's always been. It didn't even have the error info stuff in the beginning, but yeah.  It makes total sense to clear results on a query fail. We can play with it on the other calls, but this is the big one.</p>
November 2021

<p>This is staged for 5.1</p>