View Issue Detail

ID	Project	Category	Submitted / Last Updated
00692	UserSpice	Misc	2019-09-04 08:47:49 / 2020-07-22 20:05:52
Reported	Michael Buhr	Assigned To	Unassigned
Priority	none	Reported	5.0.01
Status	closed fixed	Resolution Version and Commit	5.0.03 241a1d
Summary	login redirect fails
Description	<p>initially i didn't pay much attention, but now i traced down a bug in login.php.</p> <p>due to the bug, the configured/default redirect didn't work. as well, it felt like 2 logins are required to get any further.</p> <p>pay attention to the curly brackets in line 96 and 115 in users/login.php</p> <p>wrong:</p> <p><span style="color: #6a9955; background-color: #1e1e1e; font-family: 'Droid Sans Mono', monospace, monospace, 'Droid Sans Fallback'; white-space: pre;">//check for need to reAck terms of service</span></p> <div style="color: #d4d4d4; background-color: #1e1e1e; font-family: 'Droid Sans Mono', monospace, monospace, 'Droid Sans Fallback'; line-height: 19px; white-space: pre;"> <div><span style="color: #c586c0;">if</span>(<span style="color: #9cdcfe;">$settings</span>-><span style="color: #9cdcfe;">show_tos</span> == <span style="color: #b5cea8;">1</span>){</div> <div><span style="color: #c586c0;">if</span>(<span style="color: #9cdcfe;">$user</span>-><span style="color: #dcdcaa;">data</span>()-><span style="color: #9cdcfe;">oauth_tos_accepted</span> == <span style="color: #b5cea8;">0</span>){</div> <div><span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'users/user_agreement_acknowledge.php'</span>);</div> <div>}</div> <br /><br /> <div><span style="color: #c586c0;">if</span> (!<span style="color: #dcdcaa;">empty</span>(<span style="color: #9cdcfe;">$dest</span>)) {</div> <div><span style="color: #9cdcfe;">$redirect</span>=<span style="color: #dcdcaa;">htmlspecialchars_decode</span>(<span style="color: #4ec9b0;">Input</span>::<span style="color: #dcdcaa;">get</span>(<span style="color: #ce9178;">'redirect'</span>));</div> <div><span style="color: #c586c0;">if</span>(!<span style="color: #dcdcaa;">empty</span>(<span style="color: #9cdcfe;">$redirect</span>) \|\| <span style="color: #9cdcfe;">$redirect</span>!==<span style="color: #ce9178;">''</span>) <span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$redirect</span>);</div> <div><span style="color: #c586c0;">else</span> <span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$dest</span>);</div> <div>} <span style="color: #c586c0;">elseif</span> (<span style="color: #dcdcaa;">file_exists</span>(<span style="color: #9cdcfe;">$abs_us_root</span>.<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'usersc/scripts/custom_login_script.php'</span>)) {</div> <br /> <div><span style="color: #6a9955;"># if site has custom login script, use it</span></div> <div><span style="color: #6a9955;"># Note that the custom_login_script.php normally contains a Redirect::to() call</span></div> <div><span style="color: #c586c0;">require_once</span> <span style="color: #9cdcfe;">$abs_us_root</span>.<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'usersc/scripts/custom_login_script.php'</span>;</div> <div>} <span style="color: #c586c0;">else</span> {</div> <div><span style="color: #c586c0;">if</span> ((<span style="color: #9cdcfe;">$dest</span> = <span style="color: #4ec9b0;">Config</span>::<span style="color: #dcdcaa;">get</span>(<span style="color: #ce9178;">'homepage'</span>)) \|\|</div> <div>(<span style="color: #9cdcfe;">$dest</span> = <span style="color: #ce9178;">'account.php'</span>)) {</div> <div><span style="color: #6a9955;">#echo "DEBUG: dest=$dest<br />\n";</span></div> <div><span style="color: #6a9955;">#die;</span></div> <div><span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$dest</span>);</div> <div>}</div> <div>}</div> <div>}</div> <div>} <span style="color: #c586c0;">else</span> {</div> </div> <p> </p> <p>right:</p> <div style="color: #d4d4d4; background-color: #1e1e1e; font-family: 'Droid Sans Mono', monospace, monospace, 'Droid Sans Fallback'; line-height: 19px; white-space: pre;"> <div><span style="color: #6a9955;">//check for need to reAck terms of service</span></div> <div><span style="color: #c586c0;">if</span>(<span style="color: #9cdcfe;">$settings</span>-><span style="color: #9cdcfe;">show_tos</span> == <span style="color: #b5cea8;">1</span>){</div> <div><span style="color: #c586c0;">if</span>(<span style="color: #9cdcfe;">$user</span>-><span style="color: #dcdcaa;">data</span>()-><span style="color: #9cdcfe;">oauth_tos_accepted</span> == <span style="color: #b5cea8;">0</span>){</div> <div><span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'users/user_agreement_acknowledge.php'</span>);</div> <div>}</div> <div>}</div> <br /> <div><span style="color: #c586c0;">if</span> (!<span style="color: #dcdcaa;">empty</span>(<span style="color: #9cdcfe;">$dest</span>)) {</div> <div><span style="color: #9cdcfe;">$redirect</span>=<span style="color: #dcdcaa;">htmlspecialchars_decode</span>(<span style="color: #4ec9b0;">Input</span>::<span style="color: #dcdcaa;">get</span>(<span style="color: #ce9178;">'redirect'</span>));</div> <div><span style="color: #c586c0;">if</span>(!<span style="color: #dcdcaa;">empty</span>(<span style="color: #9cdcfe;">$redirect</span>) \|\| <span style="color: #9cdcfe;">$redirect</span>!==<span style="color: #ce9178;">''</span>) <span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$redirect</span>);</div> <div><span style="color: #c586c0;">else</span> <span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$dest</span>);</div> <div>} <span style="color: #c586c0;">elseif</span> (<span style="color: #dcdcaa;">file_exists</span>(<span style="color: #9cdcfe;">$abs_us_root</span>.<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'usersc/scripts/custom_login_script.php'</span>)) {</div> <br /> <div><span style="color: #6a9955;"># if site has custom login script, use it</span></div> <div><span style="color: #6a9955;"># Note that the custom_login_script.php normally contains a Redirect::to() call</span></div> <div><span style="color: #c586c0;">require_once</span> <span style="color: #9cdcfe;">$abs_us_root</span>.<span style="color: #9cdcfe;">$us_url_root</span>.<span style="color: #ce9178;">'usersc/scripts/custom_login_script.php'</span>;</div> <div>} <span style="color: #c586c0;">else</span> {</div> <div><span style="color: #c586c0;">if</span> ((<span style="color: #9cdcfe;">$dest</span> = <span style="color: #4ec9b0;">Config</span>::<span style="color: #dcdcaa;">get</span>(<span style="color: #ce9178;">'homepage'</span>)) \|\|</div> <div>(<span style="color: #9cdcfe;">$dest</span> = <span style="color: #ce9178;">'account.php'</span>)) {</div> <div><span style="color: #6a9955;">#echo "DEBUG: dest=$dest<br />\n";</span></div> <div><span style="color: #6a9955;">#die;</span></div> <div><span style="color: #4ec9b0;">Redirect</span>::<span style="color: #dcdcaa;">to</span>(<span style="color: #9cdcfe;">$dest</span>);</div> <div>}</div> <div>}</div> <div> </div> <div>} <span style="color: #c586c0;">else</span> {</div> <div> </div> </div>

November 2021

<p>I've never been happier with a bug report. This drove me nuts. THANK YOU for not only providing the bug but the fix</p>