View Issue Detail

ID	Project	Category	Submitted / Last Updated
00566	UserSpice	Misc	2019-05-11 23:10:26 / 2020-10-08 04:14:56
Reported	John Williams	Assigned To	Unassigned
Priority	low	Reported	4.4.07
Status	closed fixed	Resolution Version and Commit	5.1.5
Summary	Class\Validation - incorrect code.
Description	<p>File: Class\Validation</p> <p>The rules for Greater than, Less Than and other's are incorrect.</p> <p>Listed below is the corrected code.</p> <p>Correction</p> <p> </p> <p>if ($rule=="<="  &&  $value>=$rule_value)</p> <p>   $this->addError(["{$display} must be smaller than {$rule_value_display}",$item]);</p> <p> </p> <p>if ($rule==">="  &&  $value<=$rule_value)</p> <p>   $this->addError(["{$display} must be larger than {$rule_value_display}",$item]);</p> <p> </p> <p>if ($rule=="<"  &&  $value>$rule_value)</p> <p>   $this->addError(["{$display} must be equal {$rule_value_display} or smaller",$item]);</p> <p> </p> <p>if ($rule==">"  &&  $value<$rule_value)</p> <p>   $this->addError(["{$display} must be equal {$rule_value_display} or larger",$item]);</p> <p> </p> <p>if ($rule=="=="  &&  $value==$rule_value)</p> <p>   $this->addError(["{$display} must be different from {$rule_value_display}",$item]);</p> <p> </p> <p>if ($rule=="!="  &&  $value!=$rule_value)</p> <p>   $this->addError(["{$display} must equal {$rule_value_display}",$item]);</p>

November 2021

This looks like it's based off old code because it doesn't show the language in it. What version is it from?
November 2021

I see 4.4.07. What happens if you update to .11/.12
November 2021

This is 4.4.11 There is no language codes in the validation.
November 2021

Can you let me know which lines are of the original code to be replaced?
November 2021

File: users/classes/validate.php Line: 156 Current Line: if ($rule=="<"  &&  $value>=$rule_value){ Correct Code: if ($rule=="<"  &&  $value>$rule_value){   Line: 162 Current Line: $str = lang("VAL_LESS"); Correct Code: $str = lang("VAL_GREAT");   Line 161 Current Line: if ($rule==">"  &&  $value<=$rule_value){ Correct Code: if ($rule==">"  &&  $value<$rule_value){   Line 166 Current line: if ($rule=="<="  &&  $value>$rule_value){ Correct Code: if ($rule=="<="  &&  $value>=$rule_value){   Line 171 Current Line: if ($rule==">="  &&  $value<$rule_value){ Correct Code: if ($rule==">="  &&  $value<=$rule_value){   Line 176 Current Line: if ($rule=="!="  &&  $value==$rule_value){ Correct Code: if ($rule=="!="  &&  $value!=$rule_value)   Line 181 Current Line: if ($rule=="=="  &&  $value!=$rule_value){ Correct Code: if ($rule=="=="  &&  $value==$rule_value)