View Issue Detail

ID	Project	Category	Submitted / Last Updated
00467	UserSpice	Misc Code	2019-03-20 03:40:58 / 2020-10-08 04:14:56
Reported	David2278 .	Assigned To	Unassigned
Priority	low	Reported	4.4.04
Status	closed fixed	Resolution Version and Commit	5.1.5
Summary	display_errors does not select the correct html id. Terms and conditions also has no id.
Description	<p>in helpers.php the function `display_errors` adds the error text to the page, but also attaches the class "has-error" like this.</p> <p><span style="font-family: 'Courier New'; font-size: 12pt; color: #cc7832; background-color: #232525; font-weight: bold;">function </span><span style="font-family: 'Courier New'; font-size: 12pt; color: #ffc66d; background-color: #232525;">display_errors</span><span style="color: #a9b7c6; font-family: 'Courier New'; font-size: 12pt; background-color: #232525;">(</span><span style="font-family: 'Courier New'; font-size: 12pt; color: #9876aa; background-color: #232525;">$errors </span><span style="color: #a9b7c6; font-family: 'Courier New'; font-size: 12pt; background-color: #232525;">= </span><span style="font-family: 'Courier New'; font-size: 12pt; color: #cc7832; background-color: #232525; font-weight: bold;">array</span><span style="color: #a9b7c6; font-family: 'Courier New'; font-size: 12pt; background-color: #232525;">()){</span></p> <pre style="background-color: #2b2b2b; color: #a9b7c6; font-family: 'Courier New'; font-size: 12.0pt;"> <span style="color: #9876aa; background-color: #232525;">$html </span><span style="background-color: #232525;">= </span><span style="color: #6a8759; background-color: #232525;">'<ul class="bg-danger">'</span><span style="color: #cc7832; background-color: #232525;">;<br /></span> <span style="color: #cc7832; background-color: #232525; font-weight: bold;">foreach</span><span style="background-color: #232525;">(</span><span style="color: #9876aa; background-color: #232525;">$errors </span><span style="color: #cc7832; background-color: #232525; font-weight: bold;">as </span><span style="color: #9876aa; background-color: #232525;">$error</span><span style="background-color: #232525;">){<br /></span> <span style="color: #cc7832; background-color: #232525; font-weight: bold;">if</span><span style="background-color: #232525;">(is_array(</span><span style="color: #9876aa; background-color: #232525;">$error</span><span style="background-color: #232525;">)){<br /></span> <span style="color: #808080; background-color: #232525;">//echo "<br>"; Patch from user SavaageStyle - leaving here in case of rollback<br /></span> <span style="color: #9876aa; background-color: #232525;">$html </span><span style="background-color: #232525;">.= </span><span style="color: #6a8759; background-color: #232525;">'<li class="text-danger">'</span><span style="background-color: #232525;">.</span><span style="color: #9876aa; background-color: #232525;">$error</span><span style="background-color: #232525;">[</span><span style="color: #6897bb; background-color: #232525;">0</span><span style="background-color: #232525;">].</span><span style="color: #6a8759; background-color: #232525;">'</li>'</span><span style="color: #cc7832; background-color: #232525;">;<br /></span> <span style="color: #9876aa; background-color: #232525;">$html </span><span style="background-color: #232525;">.= </span><span style="color: #6a8759; background-color: #232525;">'<script></span><span style="color: #9876aa; background-color: #232525;">jQuery</span><span style="color: #6a8759; background-color: #232525;">("#'</span><span style="background-color: #232525;">.</span><span style="color: #9876aa; background-color: #232525;">$error</span><span style="background-color: #232525;">[</span><span style="color: #6897bb; background-color: #232525;">0</span><span style="background-color: #232525;">].</span><span style="color: #6a8759; background-color: #232525;">'").</span><span style="color: #ffc66d; background-color: #232525;">parent</span><span style="color: #6a8759; background-color: #232525;">().</span><span style="color: #ffc66d; background-color: #232525;">closest</span><span style="color: #6a8759; background-color: #232525;">("div").</span><span style="color: #ffc66d; background-color: #232525;">addClass</span><span style="color: #6a8759; background-color: #232525;">("has-error");</script>'</span><span style="color: #cc7832; background-color: #232525;">;<br /></span> <span style="background-color: #232525;">}</span><span style="color: #cc7832; background-color: #232525; font-weight: bold;">else</span><span style="background-color: #232525;">{<br /></span> <span style="color: #9876aa; background-color: #232525;">$html </span><span style="background-color: #232525;">.= </span><span style="color: #6a8759; background-color: #232525;">'<li class="text-danger">'</span><span style="background-color: #232525;">.</span><span style="color: #9876aa; background-color: #232525;">$error</span><span style="background-color: #232525;">.</span><span style="color: #6a8759; background-color: #232525;">'</li>'</span><span style="color: #cc7832; background-color: #232525;">;<br /></span> <span style="background-color: #232525;">}<br /></span><span style="background-color: #232525;"> }<br /></span> <span style="color: #9876aa; background-color: #232525;">$html </span><span style="background-color: #232525;">.= </span><span style="color: #6a8759; background-color: #232525;">'</ul>'</span><span style="color: #cc7832; background-color: #232525;">;<br /></span> <span style="color: #cc7832; background-color: #232525; font-weight: bold;">return </span><span style="color: #9876aa; background-color: #232525;">$html</span><span style="color: #cc7832; background-color: #232525;">;<br /></span><span style="background-color: #232525;">}</span></pre> <p>Notice the jQuery selector is using error[0]. It should be error[1]. error[0] is the description of the error (aka the error message for the user) and error[1] is the html element id that was the cause of the problem.</p> <p> </p> <p>Also, if the terms and conditions checkbox is not checked when the user goes to create an account then error[1] is blank causing the jquery to look like this `jQuery("#").stuffToDo()`</p>

November 2021

<p>Another issue is open to stop using display_errors, requeueing.</p>