View Issue Detail

ID	Project	Category	Submitted / Last Updated
00429	UserSpice	Misc Code	2019-02-09 23:59:33 / 2020-07-17 14:59:05
Reported	Brandin Arsenault	Assigned To	Unassigned
Priority	normal	Reported	4.4.01
Status	closed	Resolution Version and Commit
Summary	hashCheck on Remember me?
Description	<p>We check for a hash...but I don't think we do anything with it?</p> <p>151 on User.php</p> <p>$hashCheck = $this->_db->get('users_session' , array('user_id', '=', $this->data()->id));</p>

November 2021

This code needs to be more baked (a while command PHP for example)         $hash = Hash::unique();         $hashCheck = $db->get('users_session',['user_id' => $cUserResult->id]);         if(!$db->error()) {           if($db->count==0) {             $db->insert('users_session', array(               'user_id' => $cUserResult->id,               'hash' => $hash,               'uagent' => Session::uagent_no_version()             ));           Cookie::put(Config::get('remember/cookie_name'), $hash, Config::get('remember/cookie_expiry'));           }         } else {           logger($cUserResult->id,"Discord Login","Failed to check for Hash, Error: ".$db->errorString());         }
November 2021

The hash check appears to be used to  verify if the user is in the user_session table already. Do we need this? And if so, why aren't we using the hash from the table if it exists?
November 2021

Remember me has been pulled