View Issue Detail

ID	Project	Category	Submitted / Last Updated
00420	UserSpice	Misc Code	2019-02-04 17:33:11 / 2019-06-13 15:42:08
Reported	Rihards Simanovics	Assigned To	Unassigned
Priority	low	Reported	4.4.01
Status	closed fixed	Resolution Version and Commit	4.4.02
Summary	Just got a fresh install of UserSpice with verify.php incorrectly coded (Updated to the latest version)
Description	<p>Just got a fresh installation of UserSpice on my domain test.greatrequest.com and noticed that when creating new user verification page would load with an error stating an unexpected else. Than once fixed had an unexpected end of the file due to if statement not ended with curly bracket "}" in case if someone experienced the same issue here is the working code:</p> <p><code><span style="font-family: monospace;"><?php</span></code></p> <p><code><span style="font-family: monospace;">// This is a user-facing page</span></code></p> <p><code><span style="font-family: monospace;">/</span></code></p> <p><code><span style="font-family: monospace;">UserSpice 4</span></code></p> <p><code><span style="font-family: monospace;">An Open Source PHP User Management System</span></code></p> <p><code><span style="font-family: monospace;">by the UserSpice Team at http://UserSpice.com</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">This program is free software: you can redistribute it and/or modify</span></code></p> <p><code><span style="font-family: monospace;">it under the terms of the GNU General Public License as published by</span></code></p> <p><code><span style="font-family: monospace;">the Free Software Foundation, either version 3 of the License, or</span></code></p> <p><code><span style="font-family: monospace;">(at your option) any later version.</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">This program is distributed in the hope that it will be useful,</span></code></p> <p><code><span style="font-family: monospace;">but WITHOUT ANY WARRANTY; without even the implied warranty of</span></code></p> <p><code><span style="font-family: monospace;">MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the</span></code></p> <p><code><span style="font-family: monospace;">GNU General Public License for more details.</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">You should have received a copy of the GNU General Public License</span></code></p> <p><code><span style="font-family: monospace;">along with this program.  If not, see <http://www.gnu.org/licenses/>.</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">/</span></code></p> <p><code><span style="font-family: monospace;">require_once '../users/init.php';</span></code></p> <p><code><span style="font-family: monospace;">require_once $abs_us_root.$us_url_root.'users/includes/template/prep.php';</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">if(ipCheckBan()){Redirect::to($us_url_root.'usersc/scripts/banned.php');die();}</span></code></p> <p><code><span style="font-family: monospace;">$new=Input::get('new');</span></code></p> <p><code><span style="font-family: monospace;">if($new!=1) if($user->isLoggedIn()) $user->logout();</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">$verify_success=FALSE;</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">$errors = array();</span></code></p> <p><code><span style="font-family: monospace;">if(Input::exists('get')){</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"> $email = Input::get('email');</span></code></p> <p><code><span style="font-family: monospace;"> $vericode = Input::get('vericode');</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"> $validate = new Validate();</span></code></p> <p><code><span style="font-family: monospace;"> $validation = $validate->check($_GET,array(</span></code></p> <p><code><span style="font-family: monospace;"> 'email' => array(</span></code></p> <p><code><span style="font-family: monospace;">   'display' => 'Email',</span></code></p> <p><code><span style="font-family: monospace;">   'valid_email' => true,</span></code></p> <p><code><span style="font-family: monospace;">   'required' => true,</span></code></p> <p><code><span style="font-family: monospace;"> ),</span></code></p> <p><code><span style="font-family: monospace;"> ));</span></code></p> <p><code><span style="font-family: monospace;"> if($validation->passed()){ //if email is valid, do this</span></code></p> <p><code><span style="font-family: monospace;"> //get the user info based on the email</span></code></p> <p><code><span style="font-family: monospace;"> $verify = new User(Input::get('email'));</span></code></p> <p><code><span style="font-family: monospace;"> if($verify->data()->email_verified == 1 && $verify->data()->vericode == $vericode){</span></code></p> <p><code><span style="font-family: monospace;"> //email is already verified - Basically if the system already shows the email as verified and they click the link again, we're going to pass it regardless of the expiry because</span></code></p> <p><code><span style="font-family: monospace;"> //the hassle of telling people verification failed (after previously successful is worse than what could go wrong)</span></code></p> <p><code><span style="font-family: monospace;"> require $abs_us_root.$us_url_root.'users/views/_verify_success.php';</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> elseif($verify->data()->email_verified != 1 && $verify->data()->vericode_expiry == "0000-00-00 00:00:00"){</span></code></p> <p><code><span style="font-family: monospace;"> //in the unlikely event someone has a blank vericode expiry, we're going to generate a new one</span></code></p> <p><code><span style="font-family: monospace;"> $vericode_expiry=date("Y-m-d H:i:s",strtotime("+$settings->join_vericode_expiry hours",strtotime(date("Y-m-d H:i:s"))));</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"> echo "Something is strange. Please re-verify your email. We are sorry for the inconvenience";</span></code></p> <p><code><span style="font-family: monospace;"> $verify->update(array('email_verified' => 0,'vericode' => randomstring(15),'vericode_expiry' => $vericode_expiry),$verify->data()->id);</span></code></p> <p><code><span style="font-family: monospace;"> require $abs_us_root.$us_url_root.'users/views/_verify_resend.php';</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> else{</span></code></p> <p><code><span style="font-family: monospace;"> if ($verify->exists() && $verify->data()->vericode == $vericode && (strtotime($verify->data()->vericode_expiry) - strtotime(date("Y-m-d H:i:s")) > 0)){</span></code></p> <p><code><span style="font-family: monospace;"> //check if this email account exists in the DB</span></code></p> <p><code><span style="font-family: monospace;"> if($new==1 && !$verify->data()->email_new == NULL){</span></code></p> <p><code><span style="font-family: monospace;"> $verify->update(array('email_verified' => 1,'vericode' => randomstring(15),'vericode_expiry' => date("Y-m-d H:i:s"),'email' => $verify->data()->email_new,'email_new' => NULL),$verify->data()->id);</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> else{</span></code></p> <p><code><span style="font-family: monospace;"> $verify->update(array('email_verified' => 1,'vericode' => randomstring(15),'vericode_expiry' => date("Y-m-d H:i:s")),$verify->data()->id);</span></code></p> <p><code><span style="font-family: monospace;"> $verify_success=TRUE;</span></code></p> <p><code><span style="font-family: monospace;"> logger($verify->data()->id,"User","Verification completed via vericode.");</span></code></p> <p><code><span style="font-family: monospace;"> if($new==1) Redirect::to($us_url_root.'users/user_settings.php?msg=Email Updated Successfully');</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> else{</span></code></p> <p><code><span style="font-family: monospace;"> $errors = $validation->errors();</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;"> }</span></code></p> <p><code><span style="font-family: monospace;">}</span></code></p> <p><code><span style="font-family: monospace;">?></span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"><div id="page-wrapper"></span></code></p> <p><code><span style="font-family: monospace;"><div class="container"></span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"><?php</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">if ($verify_success)</span></code></p> <p><code><span style="font-family: monospace;">{</span></code></p> <p><code><span style="font-family: monospace;"> require $abs_us_root.$us_url_root.'users/views/_verify_success.php';</span></code></p> <p><code><span style="font-family: monospace;">}</span></code></p> <p><code><span style="font-family: monospace;">else</span></code></p> <p><code><span style="font-family: monospace;">{</span></code></p> <p><code><span style="font-family: monospace;"> require $abs_us_root.$us_url_root.'users/views/_verify_error.php';</span></code></p> <p><code><span style="font-family: monospace;">}</span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">?></span></code></p> <p><code><span style="font-family: monospace;"><br></span></code></p> <p><code><span style="font-family: monospace;"></div></span></code></p> <p><code><span style="font-family: monospace;"></div></span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"><?php</span></code></p> <p><code><span style="font-family: monospace;">require_once $abs_us_root.$us_url_root.'users/includes/page_footer.php'; // the final html footer copyright row + the external js calls</span></code></p> <p><code><span style="font-family: monospace;">?></span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;">  <!-- Place any per-page javascript here --></span></code></p> <p><code><span style="font-family: monospace;"> </span></code></p> <p><code><span style="font-family: monospace;"><?php require_once $abs_us_root.$us_url_root.'users/includes/html_footer.php'; // currently just the closing /body and /html ?></span></code></p>

November 2021

<p>Resolved. Thank you!</p>