View Issue Detail

ID	Project	Category	Submitted / Last Updated
01537	UserSpice	Triage	2022-06-25 00:36:03 / 2022-08-28 18:33:21
Reported	Thadius Wynter	Assigned To	Unassigned
Priority	none	Reported	5.4.4
Status	closed fixed	Resolution Version and Commit	5.4.5
Summary	Undefined BS4 classes 'pull-left' and 'pull-right' used on /users/login.php
Description	As the title states, the login.php page uses the 'pull-left' and 'pull-right' classes. These were deprecated and renamed to 'float-left' and 'float-right' respectively some time around v4.3.0, though I am unable to find the Bootstrap Blog post detailing the changelog containing it. See also: https://stackoverflow.com/questions/39655110/what-happened-to-the-pull-left-and-pull-right-classes-in-bootstrap-4 Affected references: /users/login.php:182 /users/login.php:187

June 2022

The bootstrap people seem to get a lot of joy out of changing class names. I don't see any difference in the code on the standard template, but it definitely makes sense to update it. Thank you.
June 2022

I'm also pretty sure bs5 changes most of these things from left and right to start and end, but we'll cross that bridge when I release those templates :)
June 2022

Yeah. This is going to require some other solution for the other places it's used because bs5 is different.
June 2022

Because bs keeps changing class names, we're going to need a more elegant solution to keep our templates compatible with bs4 and bs5 in the core.