View Issue Detail

ID	Project	Category	Submitted / Last Updated
01534	UserSpice	Triage	2022-06-19 17:44:59 / 2022-06-25 10:37:11
Reported	John Williams	Assigned To	Unassigned
Priority	none	Reported	5.4.4
Status	closed	Resolution Version and Commit
Summary	Using the database Feature: get($table, $where)
Description	File: users\classes\DB.php Line: 247 Here is my IF Statement: if($db->get('fb_forms',['new','=',$token])){ I know that $token did not have anything in the database. The IF statement kept on returning true. Using the following code, it would become false when the database returned 0. public function get($table, $where){ $sql = $this->action('SELECT ', $table, $where); $count = $this->count(); if($count > 0){ return $sql; }else{ return false; } //return $this->action('SELECT ', $table, $where); }

June 2022

This acts currently according to documentation of the method. The documentation states "These methods return object in case of success and "false" in case of failure. You can check for error this way:" Having no results is not a case of failure, anything causing a database error is. Although the documentation could be clearer on this. Changing this method to return false as requested would be a breaking change for existing code and I would disagree with this change. ~BangingHeads
June 2022

I have to agree. This is just shorthand for existing methods and this change would break expected behavior.