View Issue Detail

ID	Project	Category	Submitted / Last Updated
01296	UserSpice	Triage	2021-08-09 03:56:40 / 2021-08-10 09:51:19
Reported	Terry Booth	Assigned To	Unassigned
Priority	none	Reported	5.3.4
Status	closed	Resolution Version and Commit
Summary	CSS policy
Description	May I suggest a policy on css where possible to replace static css to classes . In particular the function function bin($number) { if ($number == 0) { echo "<strong><font color='red'>No</font></strong>"; } if ($number == 1) { echo "<strong><font color='green'>Yes</font></strong>"; } if ($number != 0 && $number != 1) { echo "<strong><font color='blue'>Other</font></strong>"; } } To change to function bin($number) { if ($number == 0) { echo "<strong><font class='No'>No</font></strong>"; } if ($number == 1) { echo "<strong><font class='yes'>Yes</font></strong>"; } if ($number != 0 && $number != 1) { echo "<strong><font class='other'>Other</font></strong>"; } } and have some core css somewhere ..eg <style> .yes{color:green;} .no{color:red;} .other{color:blue;} </style>

November 2021

I'm closing the ticket itself, but yes. We're definitely doing that by adding ids and classes to things as we rewrite them. In the short term, for your situation, you also have the option of creating a new function bin in usersc/includes/custom_functions.php and your function will be called instead of ours. Thanks for the tip!