View Issue Detail

ID	Project	Category	Submitted / Last Updated
01072	UserSpice	Misc Code	2020-12-16 18:24:02 / 2021-03-01 02:31:45
Reported	Dan Hoover	Assigned To	Unassigned
Priority	normal	Reported	5.2.2
Status	closed fixed	Resolution Version and Commit	5.2.3
Summary	SecurePage
Description	<p>$_SERVER['HTTP_HOST']</p> <p>wrong function. Check if currently https and if so ,redirec to https in securePage</p>

November 2021

<span style="color: #dcddde; font-family: Consolas, 'Andale Mono WT', 'Andale Mono', 'Lucida Console', 'Lucida Sans Typewriter', 'DejaVu Sans Mono', 'Bitstream Vera Sans Mono', 'Liberation Mono', 'Nimbus Mono L', Monaco, 'Courier New', Courier, monospace; font-size: 13.6px; white-space: pre-wrap; background-color: #2f3136;">$_SERVER['HTTPS']
November 2021

  <table class="diff-table js-diff-table tab-size file-diff-split js-file-diff-split" style="border-spacing: 0px; border-collapse: initial; width: 1853px; table-layout: fixed; tab-size: 8; color: #24292e; font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji';" data-tab-size="8" data-diff-anchor="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576" data-paste-markdown-skip=""> <tbody style="box-sizing: border-box;"> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') { //Catch servers that support $_SERVER['HTTPS']</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R238" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="238"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> $dest = encodeURIComponent("https://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]");</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R239" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="239"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> }</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R240" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="240"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> elseif (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https' || !empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') { //Catch servers that are HTTPS, but DON'T support $_SERVER['HTTPS'] </td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R241" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="241"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> $dest = encodeURIComponent("https://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]");</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R242" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="242"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> }</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R243" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="243"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> else { //If neither are supported or true, assume HTTPS is NOT available.</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R244" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="244"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> $dest = encodeURIComponent("http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]");</td> </tr> <tr style="box-sizing: border-box;" data-hunk="06d9ca1e2f2ca7f9d62689d73972820a0433308059b97e15758c32918c404478"> <td class="blob-num blob-num-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: default; user-select: none; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td class="blob-code blob-code-empty empty-cell" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; cursor: default; background-color: var(--color-diff-blob-empty-block-bg); border-right-color: var(--color-border-secondary);"> </td> <td id="diff-3eda88cc24f25bad264dc7fbb367415526e688964f97fa59bf0adb974320e576R245" class="blob-num blob-num-addition js-linkable-line-number" style="box-sizing: border-box; padding: 0px 10px; width: 44px; min-width: 50px; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; line-height: 20px; color: var(--color-diff-blob-addition-num-text); text-align: right; white-space: nowrap; vertical-align: top; cursor: pointer; user-select: none; background-color: var(--color-diff-blob-addition-num-bg); border-left: 1px solid var(--color-auto-gray-1);" data-line-number="245"> </td> <td class="code-review blob-code blob-code-addition" style="box-sizing: border-box; padding: 0px 10px; position: relative; line-height: 20px; vertical-align: top; background-color: var(--color-diff-blob-addition-line-bg); outline: transparent dotted 1px;"><span class="blob-code-inner blob-code-marker" style="box-sizing: border-box; overflow: visible; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, monospace; font-size: 12px; color: var(--color-text-primary); overflow-wrap: break-word; white-space: pre-wrap;" data-code-marker="+"> }</td> </tr> </tbody> </table>
November 2021

<a class="anchor-3Z-8Bb anchorUnderlineOnHover-2ESHQB" style="margin: 0px; padding: 0px; border: 0px; font-family: Whitney, 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 16px; vertical-align: baseline; cursor: pointer; outline: 0px; word-break: break-word; white-space: break-spaces; background-color: rgba(4, 4, 5, 0.07);" tabindex="0" title="https://github.com/mudmin/UserSpice5/compare/master...Torngate:patch-1" role="button" href="https://github.com/mudmin/UserSpice5/compare/master...Torngate:patch-1" target="_blank" rel="noreferrer noopener">https://github.com/mudmin/UserSpice5/compare/master...Torngate:patch-1</a>
November 2021

David_
November 2021

Thanks David_ and BangingHeads for your help.