View Issue Detail

ID	Project	Category	Submitted / Last Updated
01068	UserSpice	Misc	2020-11-25 01:31:47 / 2021-03-01 02:31:45
Reported	Espresso Dan	Assigned To	Unassigned
Priority	none	Reported	5.2.2
Status	closed fixed	Resolution Version and Commit	5.2.3
Summary	setcookie() expects at most 7 parameters, 8 given in /var/www/html/risk_userspice5.2/users/classes/Cookie.php on line 30
Description	<p>Summary says it all - setcookie appears to being passed an incorrect number of parameters.</p>

November 2021

samesite is passed as a string in an options array in PHP 7.3+. We have a boolean being passed as an eighth parameter on line 30. We would need to test for PHP version something like <code>if (version_compare(phpversion(), '7.3', '>='))</code> and pass it in the options array <code>setcookie($name, $value, time() + $expiry, $path, $domain, $secure, $httponly, ['samesite'=>$samesite])</code> with $samesite having the potential to be None, Lax, or Strict, default Strict. Preferably use their new syntax and pass the rest of the parameters in the options array as well as it makes it cleaner what variables are being set (but this only works on PHP 7.3+).
November 2021

Thanks for the report