View Issue Detail

ID	Project	Category	Submitted / Last Updated
00950	UserSpice	Misc	2020-07-28 04:05:58 / 2020-10-08 04:15:09
Reported	Banging Heads	Assigned To	Unassigned
Priority	none	Reported	5.1.4
Status	closed fixed	Resolution Version and Commit	5.1.5 e2d24a
Summary	DB first() causes error on query with no results
Description	<p>DB->first() will return an error on assoc false if the query has returned no results<br /><br /><strong>Notice</strong>: Undefined offset: 0 in <strong>users/classes/DB.php</strong> on line <strong>290</strong><strong><br /><br /></strong>The return statement is the following:<br /><br /><code>return (!$assoc \|\| $assoc && $this->count()>0)  ?  $this->results($assoc)[0]  :  [];</code><br /><br />This means if the assoc is false OR if assoc is true and count > 0.</p> <p>Realistically this just needs to be a test of whether the count > 0 as it is relevant in both cases and is not dependent on whether assoc is true or false.<br /><br /><code>return ($this->count()>0)  ?  $this->results($assoc)[0]  :  [];</code></p>

November 2021

This is somewhat intentional.  If you are calling first, you are essentially guaranteeing that there is a result there and not returning data will generally cause additional problems.  So the proper way to do it is to check for a count before calling first.   I will definitely check this solution though.     So essentially, the query isn't the ultimate problem....it's what you're doing with it.
November 2021

I'm going to push this, but you're getting an error 99.99% of the time if you call first without checking the count.  If I do $test = $db->query("SELECT * FROM users WHERE id = 2343")->first(); dump($test->username); The first line won't throw an error, but the second one will. So the situation this solves (as I can see) is calling first() and not ever doing anything with the variable after that point.