View Issue Detail

ID	Project	Category	Submitted / Last Updated
00075	UserSpice	Misc Code	2018-04-04 15:51:10 / 2018-05-19 19:15:47
Reported	Dan Hoover	Assigned To	Unassigned
Priority	low	Reported	4.3.18
Status	closed fixed	Resolution Version and Commit	4.3.19
Summary	Clean up dnd and dump functions
Description	<div class="message first" style="border: 0px; font-family: Whitney, 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 16px; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline; color: #ffffff; background-color: #36393e;"> <div class="body" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline;"> <div class="message-text" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline;"> <div class="markup" style="border: 0px; font-family: inherit; font-size: 0.9375rem; font-style: inherit; font-weight: inherit; margin: 6px 0px 0px; outline: 0px; padding: 0px; vertical-align: baseline; color: rgba(255, 255, 255, 0.701961); line-height: 1.1em; white-space: pre-wrap; word-wrap: break-word;"><code class="inline" style="border: 0px; font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 12.75px; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0.2em; vertical-align: baseline; line-height: 16px; background: #2f3136; border-radius: 3px; height: auto; width: auto;">if(!function_exists('isAdmin')) { function isAdmin() { global $user; if(hasPerm([2],$user->data()->id)){ return TRUE; } else { return FALSE; } } }</code></div> </div> </div> <div class="accessory" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px 4px 0px 0px; vertical-align: baseline; -webkit-box-align: start; -webkit-box-direction: normal; -webkit-box-orient: vertical; align-items: flex-start; display: flex; flex-direction: column;"> </div> </div> <div class="message" style="border: 0px; font-family: Whitney, 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 16px; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline; color: #ffffff; background-color: #36393e;"> <div class="body" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline;"> <div class="message-text" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline;"> <div class="btn-option" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0px; vertical-align: baseline; background: url('../../assets/d260979c53d0cb8e8a1f6e88e34f0056.svg') 50% center no-repeat; cursor: pointer; float: right; height: 16px; opacity: 0.4; visibility: hidden; width: 16px;"> </div> <div class="btn-reaction" style="border: 0px; font-family: inherit; font-style: inherit; font-weight: inherit; margin: 0px 4px 0px 0px; outline: 0px; padding: 0px; vertical-align: baseline; background: url('../../assets/24e5837679a970699e904d047c741540.svg') 50% center no-repeat; cursor: pointer; float: right; height: 16px; opacity: 0.4; visibility: hidden; width: 16px;"> </div> <div class="markup" style="border: 0px; font-family: inherit; font-size: 0.9375rem; font-style: inherit; font-weight: inherit; margin: 6px 0px 0px; outline: 0px; padding: 0px; vertical-align: baseline; color: rgba(255, 255, 255, 0.701961); line-height: 1.1em; white-space: pre-wrap; word-wrap: break-word;">And then in helpers.php changed the dnd() function to..... <code class="inline" style="border: 0px; font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 12.75px; font-style: inherit; font-weight: inherit; margin: 0px; outline: 0px; padding: 0.2em; vertical-align: baseline; line-height: 16px; background: #2f3136; border-radius: 3px; height: auto; width: auto;">//preformatted dump and die function function dnd($var){ if(isAdmin()){ echo "<pre>"; var_dump($var); echo "</pre>"; die(); } }</code></div> </div> </div> </div>

November 2021

After talking with Brandin, here's a revision which allows `dnd()` to only execute if the user is an admin OR if the user is cloaked (which will generally be an admin anyway).  This is super powerful because you could be logged in as a user in one browser, then as an admin which is cloaked into that user on another browser to make comparisons! ` //preformatted dump and die function function dnd($var){     if(isAdmin() || isset($_SESSION['cloak_to'])){         echo "<pre>";         var_dump($var);         echo "</pre>";         die();     } } `   And additional possiblity is adding optional parameters to the `dnd()` function which would allow developers to specify the function to only execute if it's an admin, or if the environment is local, etc. Example: `dnd(WHAT YOU WANT TO DUMP,$adminOnly=NULL,$localhostOnly=NULL)`
November 2021

Commits: 6245ac4 New Functions: isAdmin(),isLocalhost() Updated Functions: dump,dnd, both allow optional parameters of adminOnly and localhostOnly