View Issue Detail

ID	Project	Category	Submitted / Last Updated
01654	UserSpice	Triage	2023-01-30 15:45:23 / 2023-02-10 20:31:28
Reported	Renato Fridschtein	Resolved By	Dan Hoover
Priority	none	Reported	5.5.4
Status	resolved fixed	Resolution Version and Commit	5.5.7
Summary	Fix error message definition on join form validation
Description	Dear Dan, I was looking for something else and stumble upon this issue on /users/classes/Validate.php around line 103: case 'unique': ... if ($this->_db->get($table, $fields)) { $str = lang("VAL_EXISTS"); $str1 = lang("VAL_DB"); <-- var definition as DB error if ($this->_db->count()){ $this->addError(["{$display} $str {$display}",$item]); $this->ruleBroken([$item,"unique",false]); } } else { $this->addError([$str1,$item]); <-- var use do not get error but prior definition $this->ruleBroken([$item,"unique",false]); } in this code, when $str1 is used in addError() it's value is not empty so no breaking errors occur, but the value is incorrect. Not sure if this is indeed a bug or feature ;-) still to fix it, just moved the line to where I believe it should be: case 'unique': ... if ($this->_db->get($table, $fields)) { $str = lang("VAL_EXISTS"); if ($this->_db->count()){ $this->addError(["{$display} $str {$display}",$item]); $this->ruleBroken([$item,"unique",false]); } } else { $str1 = lang("VAL_DB"); // <-- new position $this->addError([$str1,$item]); // or even combine the two lines so no need for $str1: $this->addError([lang("VAL_DB"),$item]); $this->ruleBroken([$item,"unique",false]); } hope it helps.

last month

Thank you so much for this, Renato. This will go out in 5.5.5